seawinde opened a new pull request, #52993:
URL: https://github.com/apache/doris/pull/52993

   ### What problem does this PR solve?
   
   If agg table is random hash distribute, would add aggregate node on scan.
   The aggregate function alias expr id is same to the child expr id of alias.
   
   such as query sql is `select * from db1.tagg`
   the query plan is as following, and the `sum(b#1) AS `b`#1`, alias expr id 
is same to the child expr id of alias, the id is 1
   this would cause hidden problems
   ```sql
   LogicalResultSink[30] ( outputExprs=[a#0, b#1] )
   +--LogicalAggregate[29] ( groupByExpr=[a#0], outputExpr=[a#0, sum(b#1) AS 
`b`#1], hasRepeat=false, stats=1 )
      +--LogicalOlapScan ( qualified=internal.db1.tagg, 
indexName=<index_not_selected>, selectedIndexId=1752042452160, preAgg=ON, 
operativeCol=[a#0, b#1], stats=1 )
   ```
   
   the pr fix this, and the expression  change to `sum(b#1) AS `b`#4`  
   ```sql
   LogicalResultSink[30] ( outputExprs=[a#0, b#4] )
   +--LogicalAggregate[29] ( groupByExpr=[a#0], outputExpr=[a#0, sum(b#1) AS 
`b`#4], hasRepeat=false, stats=1 )
      +--LogicalOlapScan ( qualified=internal.db1.tagg, 
indexName=<index_not_selected>, selectedIndexId=1752042065062, preAgg=ON, 
operativeCol=[a#0, b#1], stats=1 )
   ```
   
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: 
https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should 
merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to