englefly commented on code in PR #11812:
URL: https://github.com/apache/doris/pull/11812#discussion_r950129319
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/MultiJoin.java:
##########
@@ -165,11 +196,14 @@ public Void visit(Plan plan, Void context) {
return null;
}
+ //TODO: add a rule to push filter condition down to join if acceptable.
+ // We can not simply add filter predicates into join conditions for
outer/anti join.
+ // It is better to add another rule to push down acceptable filter
conditions to join.
Review Comment:
yes. I will delete it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
