wangshuo128 commented on code in PR #11812:
URL: https://github.com/apache/doris/pull/11812#discussion_r951000690
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/MultiJoin.java:
##########
@@ -74,25 +91,30 @@ public Optional<Plan> reorderJoinsAccordingToConditions() {
*/
private Plan reorderJoinsAccordingToConditions(List<Plan> joinInputs,
List<Expression> conjuncts) {
if (joinInputs.size() == 2) {
- Set<Slot> joinOutput = getJoinOutput(joinInputs.get(0),
joinInputs.get(1));
- Map<Boolean, List<Expression>> split = splitConjuncts(conjuncts,
joinOutput);
- List<Expression> joinConditions = split.get(true);
- List<Expression> nonJoinConditions = split.get(false);
-
+ //Set<Slot> joinOutput = getJoinOutput(joinInputs.get(0),
joinInputs.get(1));
+ //Map<Boolean, List<Expression>> split = splitConjuncts(conjuncts,
joinOutput);
+ //List<Expression> joinConditions = split.get(true);
+ //List<Expression> nonJoinConditions = split.get(false);
+ Pair<List<Expression>, List<Expression>> pair =
JoinUtils.extractExpressionForHashTable(
+
joinInputs.get(0).getOutput().stream().map(SlotReference.class::cast).collect(Collectors.toList()),
Review Comment:
`getExprId` is defined in the base class `NamedExpression`, you could get
exprId from Slot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
