zhiqiang-hhhh commented on code in PR #52701:
URL: https://github.com/apache/doris/pull/52701#discussion_r2227188115
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -2184,7 +2316,7 @@ Status
SegmentIterator::_next_batch_internal(vectorized::Block* block) {
// step 3.2: read remaining expr column and evaluate it.
if (_is_need_expr_eval) {
// The predicate column contains the remaining expr
column, no need second read.
- if (!_non_predicate_column_ids.empty()) {
+ if (_non_predicate_column_ids.size() > 0) {
Review Comment:
> why change this?
maybe clang-tidy suggestion during dev. It can be revert, I have no problem
with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
