zhiqiang-hhhh commented on code in PR #52701:
URL: https://github.com/apache/doris/pull/52701#discussion_r2230051607


##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -485,6 +496,12 @@ Status SegmentIterator::_prepare_seek(const 
StorageReadOptions::KeyRange& key_ra
     // create used column iterator
     for (auto cid : _seek_schema->column_ids()) {
         if (_column_iterators[cid] == nullptr) {
+            // TODO: Do we need this?

Review Comment:
   > Is there any possible that virtual column use key range to seek?
   
   Currently, no. Predicate on Virtual column will not be processed as 
ColumnPredicate, so `_seek_schema` do not have virtual column.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to