HappenLee commented on code in PR #53742:
URL: https://github.com/apache/doris/pull/53742#discussion_r2246867434
##########
be/src/vec/functions/date_format_type.h:
##########
@@ -131,17 +156,20 @@ struct yyyyImpl {
}
};
-using FormatImplVariant = std::variant<NoneImpl, yyyyMMddImpl, yyyy_MM_ddImpl,
+using FormatImplVariant = std::variant<UserDefinedImpl, yyyyMMddImpl,
yyyy_MM_ddImpl,
yyyy_MM_dd_HH_mm_ssImpl, yyyy_MMImpl,
yyyyMMImpl, yyyyImpl>;
const static std::string default_format = "yyyy-MM-dd HH:mm:ss";
+const static std::string default_format_decimal = "%Y-%m-%d %H:%i:%s.%f";
Review Comment:
the const value should be UPPER contain the origin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
