HappenLee commented on code in PR #53742:
URL: https://github.com/apache/doris/pull/53742#discussion_r2246868620
##########
be/src/vec/functions/date_time_transforms.h:
##########
@@ -266,24 +270,55 @@ struct DateFormatImpl {
}
};
+template <bool WithStringArg, bool NewVersion = false>
struct FromUnixTimeImpl {
- using FromType = Int64;
+ using CppType = Int64;
Review Comment:
what's the different of two this? use the same type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
