morrySnow commented on code in PR #54353:
URL: https://github.com/apache/doris/pull/54353#discussion_r2255778152
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/ExpressionTranslator.java:
##########
@@ -367,6 +367,11 @@ private Expr toBalancedTree(int low, int high, List<Expr>
children,
Expr left = children.get(l);
Expr right = children.get(h);
CompoundPredicate cp = new CompoundPredicate(op, left,
right);
+ boolean nullable =
left.getNullableFromNereids().isPresent() && left.getNullableFromNereids().get()
+ || left.isNullable()
+ || right.getNullableFromNereids().isPresent() &&
right.getNullableFromNereids().get()
+ || right.isNullable();
+ cp.setNullableFromNereids(nullable);
Review Comment:
i think we should only rely on `NullableFromNereids`. in which case
NullableFromNereids is not present?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
