yiguolei commented on code in PR #54760:
URL: https://github.com/apache/doris/pull/54760#discussion_r2281144979
##########
be/src/olap/types.h:
##########
@@ -1046,11 +1047,7 @@ struct FieldTypeTraits<FieldType::OLAP_FIELD_TYPE_FLOAT>
return Status::OK();
}
static std::string to_string(const void* src) {
- char buf[1024] = {'\0'};
Review Comment:
看一下field type traits 有没有单侧，没有的话，补充一下。 单测要覆盖2种情况：
1. 提前保存好的string字符串，可以使用from string 返序列化出来。
2. 在一个test 中，使用to string和from string 可以对一个double 做序列化和反序列化操作，同时这俩值相等。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
