jacktengg commented on code in PR #54760:
URL: https://github.com/apache/doris/pull/54760#discussion_r2282375111
##########
be/src/olap/types.h:
##########
@@ -1046,11 +1047,7 @@ struct FieldTypeTraits<FieldType::OLAP_FIELD_TYPE_FLOAT>
return Status::OK();
}
static std::string to_string(const void* src) {
- char buf[1024] = {'\0'};
- int length = to_buffer(*reinterpret_cast<const CppType*>(src),
MAX_FLOAT_STR_LENGTH, buf);
- DCHECK(length >= 0) << "gcvt float failed, float value="
- << *reinterpret_cast<const CppType*>(src);
- return std::string(buf);
+ return vectorized::CastToString::from_number(*reinterpret_cast<const
CppType*>(src));
Review Comment:
cast string不区分严格模式和非严格模式吧。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
