JNSimba commented on code in PR #335:
URL:
https://github.com/apache/doris-spark-connector/pull/335#discussion_r2283865994
##########
spark-doris-connector/spark-doris-connector-base/src/main/java/org/apache/doris/spark/client/read/ReaderPartitionGenerator.java:
##########
@@ -76,6 +76,12 @@ public static DorisReaderPartition[]
generatePartitions(DorisConfig config,
}
String[] finalReadColumns = getFinalReadColumns(config, frontend, db,
table, originReadCols);
String finalReadColumnString = String.join(",", finalReadColumns);
+
+ if (filters.length == 0 &&
config.contains(DorisOptions.DORIS_FILTER_QUERY)) {
+ LOG.info("using config option DORIS_FILTER_QUERY: {}",
config.getValue(DorisOptions.DORIS_FILTER_QUERY));
+ filters = new
String[]{config.getValue(DorisOptions.DORIS_FILTER_QUERY)};
+ }
+
Review Comment:
It is best to add an ITCase, refer to this
https://github.com/apache/doris-spark-connector/blob/master/spark-doris-connector/spark-doris-connector-it/src/test/java/org/apache/doris/spark/sql/DorisReaderITCase.scala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
