JNSimba commented on code in PR #339:
URL:
https://github.com/apache/doris-spark-connector/pull/339#discussion_r2362611380
##########
spark-doris-connector/spark-doris-connector-spark-3.3/src/main/scala/org/apache/doris/spark/read/expression/V2ExpressionBuilder.scala:
##########
@@ -72,7 +86,8 @@ class V2ExpressionBuilder(inValueLengthLimit: Int) {
fragment.append(" END")
fragment.mkString
- case _ => null
+ case "COALESCE" =>
s"COALESCE(${e.children().map(build).mkString(",")})"
+ case _ => throw new IllegalArgumentException(s"Unsupported
expression: ${e.name()}")
Review Comment:
There may be problems here. In theory, if it cannot be pushed forward, it
should not report an error, but let Spark handle it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
