wumeibanfa commented on code in PR #56600:
URL: https://github.com/apache/doris/pull/56600#discussion_r2390093258
##########
be/src/udf/udf.cpp:
##########
@@ -150,9 +150,9 @@ void*
FunctionContext::get_function_state(FunctionStateScope scope) const {
}
}
-StringRef FunctionContext::create_temp_string_val(int64_t len) {
+Slice FunctionContext::create_temp_string_val(int64_t len) {
Review Comment:
This code comes from `do_money_format` in `function_string.h`? I've also
modified it. I think the only difference between `stringref` and `slice` lies
in `const char *` versus `char *`? If we need some string operations, could we
extend `slice`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
