freemandealer commented on code in PR #55772:
URL: https://github.com/apache/doris/pull/55772#discussion_r2469955151
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -4852,6 +4886,17 @@ public TQueryOptions toThrift() {
tResult.setHnswCheckRelativeDistance(hnswCheckRelativeDistance);
tResult.setHnswBoundedQueue(hnswBoundedQueue);
tResult.setMergeReadSliceSize(mergeReadSliceSizeBytes);
+
+ if (policyFileCacheQueryLimitPercent >= 0) {
+
tResult.setFileCacheQueryLimitPercent((policyFileCacheQueryLimitPercent % 100
== 0)
Review Comment:
% 100 == 0? 这个条件好奇怪。如果我设置成 0 ，这里 percent 会被赋值为 100? 设置 101 则会赋值成 101?
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -4852,6 +4886,17 @@ public TQueryOptions toThrift() {
tResult.setHnswCheckRelativeDistance(hnswCheckRelativeDistance);
tResult.setHnswBoundedQueue(hnswBoundedQueue);
tResult.setMergeReadSliceSize(mergeReadSliceSizeBytes);
+
+ if (policyFileCacheQueryLimitPercent >= 0) {
Review Comment:
policyFileCacheQueryLimitPercent 可以覆盖 file_cache_query_limit_percent_soft ？
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -4852,6 +4886,17 @@ public TQueryOptions toThrift() {
tResult.setHnswCheckRelativeDistance(hnswCheckRelativeDistance);
tResult.setHnswBoundedQueue(hnswBoundedQueue);
tResult.setMergeReadSliceSize(mergeReadSliceSizeBytes);
+
+ if (policyFileCacheQueryLimitPercent >= 0) {
+
tResult.setFileCacheQueryLimitPercent((policyFileCacheQueryLimitPercent % 100
== 0)
+ ? 100 : policyFileCacheQueryLimitPercent);
+ } else if (fileCacheQueryLimitPercent >= 0) {
+
tResult.setFileCacheQueryLimitPercent(Math.min((fileCacheQueryLimitPercent %
100 == 0)
Review Comment:
同上
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
