wenzhenghu commented on code in PR #55772:
URL: https://github.com/apache/doris/pull/55772#discussion_r2476125207
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -4852,6 +4886,17 @@ public TQueryOptions toThrift() {
tResult.setHnswCheckRelativeDistance(hnswCheckRelativeDistance);
tResult.setHnswBoundedQueue(hnswBoundedQueue);
tResult.setMergeReadSliceSize(mergeReadSliceSizeBytes);
+
+ if (policyFileCacheQueryLimitPercent >= 0) {
+
tResult.setFileCacheQueryLimitPercent((policyFileCacheQueryLimitPercent % 100
== 0)
Review Comment:
1. policyFileCacheQueryLimitPercent默认值是-1。如果管理员通过workload
policy配置了policyFileCacheQueryLimitPercent （>=
0），那么最终的值取决于policyFileCacheQueryLimitPercent，但不会超过100，我们把0处理成100，而不是不能用filecache，因为已经有disable
file cache这个配置用来禁止session使用cache
2.
如果管理员没有设置policyFileCacheQueryLimitPercent，那看看fileCacheQueryLimitPercent是否被用户设置了，默认值也是-1。如果被设置，还是一样的处理方式，但此时最大值是file_cache_query_limit_percent_soft
3. 如果两个参数都没有设置，那就直接取file_cache_query_limit_percent_soft，也就是最终真正的默认值是它
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
