yiguolei commented on code in PR #57702:
URL: https://github.com/apache/doris/pull/57702#discussion_r2541142215
##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -248,12 +250,31 @@ Status ColumnReader::create(const ColumnReaderOptions&
opts, const SegmentFooter
uint32_t column_id, uint64_t num_rows,
Review Comment:
我们之前这个接口有点失误，我们不应该传递footer，应该在外部把variant的subcolumns 这些解析出来，然后构建reader。
这里如果列真的很多，我们parse_external_meta_pointers 这个函数的计算复杂度还是很高的。
如果是在segment 里，我们就可以一把计算好，每个column metapb 在segment
文件里的offset和length，下次查询就只要在map 里找就可以了。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
