yiguolei commented on code in PR #57702:
URL: https://github.com/apache/doris/pull/57702#discussion_r2554833314
##########
be/src/olap/rowset/segment_v2/column_reader_cache.cpp:
##########
@@ -155,31 +170,58 @@ Status ColumnReaderCache::get_path_column_reader(uint32_t
col_uid,
->get_subcolumn_meta_by_path(relative_path)
: nullptr;
}
- if (node != nullptr) {
- // lazy create column reader from footer
- DCHECK_GE(node->data.footer_ordinal, 0);
- std::shared_ptr<SegmentFooterPB> footer_pb_shared;
- {
- std::lock_guard<std::mutex> lock(_cache_mutex);
- // keep the lock until the footer is loaded, since
_get_segment_footer is not thread safe
- RETURN_IF_ERROR(_segment->_get_segment_footer(footer_pb_shared,
stats));
- }
- const auto& col_footer_pb =
footer_pb_shared->columns(node->data.footer_ordinal);
+
Review Comment:
这里直接把get_path_column_reader 这个函数分成2个函数吧，一个 get_path_column_reader_v2
另外一个get_path_column_reader_v3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
