Copilot commented on code in PR #58034: URL: https://github.com/apache/doris/pull/58034#discussion_r2544205609
########## be/src/exec/schema_scanner/schema_database_properties_scanner.h: ########## @@ -0,0 +1,55 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once +#include <gen_cpp/FrontendService_types.h> + +#include <vector> + +#include "common/status.h" +#include "exec/schema_scanner.h" + +namespace doris { +class RuntimeState; +namespace vectorized { +class Block; +} + +class SchemaDatabasePropertiesScanner : public SchemaScanner { + ENABLE_FACTORY_CREATOR(SchemaDatabasePropertiesScanner); + +public: + SchemaDatabasePropertiesScanner(); + ~SchemaDatabasePropertiesScanner() override = default; + + Status start(RuntimeState* state) override; + Status get_next_block_internal(vectorized::Block* block, bool* eos) override; + + static std::vector<SchemaScanner::ColumnDesc> _s_tbls_columns; + +private: + Status get_onedb_info_from_fe(int64_t dbId); + bool check_and_mark_eos(bool* eos) const; + int _block_rows_limit = 4096; + int _row_idx = 0; + int _total_rows = 0; + int _db_index = 0; + TGetDbsResult _db_result; + std::unique_ptr<vectorized::Block> _dbproperties_block = nullptr; + int _rpc_timeout_ms = 3000; +}; +} // namespace doris Review Comment: The namespace closing should include a semicolon to match the project's code style convention. Most other scanner header files in the same directory use `}; // namespace doris` (with semicolon). For consistency with files like schema_table_properties_scanner.h, schema_active_queries_scanner.h, and others, this should be `}; // namespace doris`. ```suggestion }; // namespace doris ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
