koarz commented on code in PR #58368:
URL: https://github.com/apache/doris/pull/58368#discussion_r2583518163


##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/action/StreamLoadAction.groovy:
##########
@@ -236,9 +287,102 @@ class StreamLoadAction implements SuiteAction {
         } catch (Throwable t) {
             ex = t
         }
+        long endTime = System.currentTimeMillis()
+
+        log.info("Stream load elapsed ${endTime - startTime} ms, is http 
stream: ${isHttpStream}, " +
+                " response: ${responseText}" + ex.toString())
         checkResult(isHttpStream, responseText, ex, startTime, 
System.currentTimeMillis())
     }
 
+    private CloseableHttpClient buildHttpClient() {
+        // Build request config if any timeout is configured
+        def requestConfig = null
+        if (connectTimeout > 0 || socketTimeout > 0 || 
connectionRequestTimeout > 0) {
+            def builder = org.apache.http.client.config.RequestConfig.custom()
+            if (connectTimeout > 0) {
+                builder.setConnectTimeout(connectTimeout)
+            }
+            if (socketTimeout > 0) {
+                builder.setSocketTimeout(socketTimeout)
+            }
+            if (connectionRequestTimeout > 0) {
+                builder.setConnectionRequestTimeout(connectionRequestTimeout)
+            }
+            requestConfig = builder.build()
+        }
+
+        def cm = null
+        if (enableUtf8Encoding) {
+            // set UTF-8
+            def connConfig = ConnectionConfig.custom()
+                .setCharset(StandardCharsets.UTF_8)
+                .setMalformedInputAction(CodingErrorAction.REPLACE)
+                .setUnmappableInputAction(CodingErrorAction.REPLACE)
+                .build()
+            cm = new PoolingHttpClientConnectionManager()
+            cm.setDefaultConnectionConfig(connConfig)
+            log.info("Stream load using UTF-8 encoding for headers")
+        }
+
+        if (!enableTLS) {
+            if (requestConfig != null) {

Review Comment:
   这块换个写法
   ```txt
   if (!enableTLS) {
       if (cm == null && requestConfig == null) {
           return HttpClients.createDefault();
       }
   
       HttpClientBuilder builder = HttpClients.custom();
   
       if (cm != null) {
           builder.setConnectionManager(cm);
       }
   
       if (requestConfig != null) {
           builder.setDefaultRequestConfig(requestConfig);
       }
   
       return builder.build();
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to