koarz commented on code in PR #58368:
URL: https://github.com/apache/doris/pull/58368#discussion_r2583521351


##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/suite/Suite.groovy:
##########
@@ -1873,8 +1873,17 @@ class Suite implements GroovyInterceptable {
             // e.g: jdbc:mysql://locahost:8080
             sql_port = 
urlWithoutSchema.substring(urlWithoutSchema.indexOf(":") + 1)
         }
+        def tlsUrl = null
         // set server side prepared statement url
-        return "jdbc:mysql://" + sql_ip + ":" + sql_port + "/" + database + 
"?&useServerPrepStmts=true"
+        if 
((context.config.otherConfigs.get("enableTLS")?.toString()?.equalsIgnoreCase("true"))
 ?: false) {
+            String useSslconfig = 
"useSSL=true&requireSSL=true&verifyServerCertificate=true"
+            String clientCAKey = "clientCertificateKeyStoreUrl=file:" + 
context.config.otherConfigs.get("keyStorePath")
+            String clientCAPwd = "clientCertificateKeyStorePassword=" + 
context.config.otherConfigs.get("keyStorePassword")
+            String trustCAKey = "trustCertificateKeyStoreUrl=file:" + 
context.config.otherConfigs.get("trustStorePath")
+            String trustCAPwd = "trustCertificateKeyStorePassword=" + 
context.config.otherConfigs.get("trustStorePassword")
+            tlsUrl = useSslconfig + "&" + clientCAKey + "&" + clientCAPwd + 
"&" +  trustCAKey + "&" + trustCAPwd
+        }
+        return "jdbc:mysql://" + sql_ip + ":" + sql_port + "/" + database + 
"?&useServerPrepStmts=true&" + tlsUrl

Review Comment:
   tlsUrl是null这里以&结尾了,感觉会出问题



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to