BiteTheDDDDt opened a new pull request, #58833:
URL: https://github.com/apache/doris/pull/58833
### What problem does this PR solve?
make scanner wait worker timer more more accurate
This pull request refactors how scanner resource usage counters are updated
in `ScannerScheduler::_scanner_scan`. The update logic for scan CPU time and
real-time counters is now managed using a deferred execution pattern, ensuring
counters are updated immediately after scanning, regardless of how the function
exits. This change improves reliability and correctness, especially in error
scenarios.
Resource usage counter updates:
* Replaced the manual update of scan CPU time and real-time counters at the
end of the function with a `Defer` object that ensures these counters are
updated as soon as possible after scanning, even if the function exits early.
* Removed the previous explicit counter update block at the end of the
function, as this is now handled by the deferred logic.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]