liaoxin01 opened a new pull request, #59710:
URL: https://github.com/apache/doris/pull/59710
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #54395
Problem Summary:
When skip_writing_empty_rowset_metadata is enabled, empty rowsets are not
committed to meta-service. Previously, set_txn_related_delete_bitmap() would
either:
1. Store full rowset info in cache (causing memory leak since
sync_tablet_delete_bitmap_by_cache() never cleans it up), or
2. Skip storing entirely (causing CalcDeleteBitmapTask to fail with
NOT_FOUND error)
This fix introduces a lightweight marker mechanism:
- For empty rowsets, store only a TxnKey marker (~16 bytes) instead of full
rowset info
- CalcDeleteBitmapTask checks for marker via is_empty_rowset() and returns
success if found (marker is NOT removed to support task retry)
- Cleanup is handled by expiration-based removal in
remove_expired_tablet_txn_info()
- Expiration time is consistent with set_tablet_txn_info()
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
