gavinchou commented on code in PR #59710:
URL: https://github.com/apache/doris/pull/59710#discussion_r2674827612
##########
be/src/cloud/cloud_txn_delete_bitmap_cache.cpp:
##########
@@ -272,6 +283,31 @@ void
CloudTxnDeleteBitmapCache::remove_unused_tablet_txn_info(TTransactionId tra
}
}
+void CloudTxnDeleteBitmapCache::mark_empty_rowset(TTransactionId txn_id,
int64_t tablet_id,
+ int64_t txn_expiration) {
+ int64_t txn_expiration_min =
+
duration_cast<std::chrono::seconds>(std::chrono::system_clock::now().time_since_epoch())
+ .count() +
+ config::tablet_txn_info_min_expired_seconds;
+ txn_expiration = std::max(txn_expiration_min, txn_expiration);
+
+ std::unique_lock<std::shared_mutex> wlock(_rwlock);
+ TxnKey txn_key(txn_id, tablet_id);
+ _empty_rowset_markers.emplace(txn_key);
+ _expiration_txn.emplace(txn_expiration, txn_key);
+
+ LOG_INFO("mark empty rowset")
Review Comment:
better LOG outside lock?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
