gavinchou commented on code in PR #60467:
URL: https://github.com/apache/doris/pull/60467#discussion_r2789485610
##########
gensrc/thrift/FrontendService.thrift:
##########
@@ -1717,6 +1730,8 @@ service FrontendService {
TFrontendPingFrontendResult ping(1: TFrontendPingFrontendRequest request)
+ Status.TStatus syncCloudVersion(1: TFrontendSyncCloudVersionRequest
request)
Review Comment:
it seems RPC name should be `pushVersionToFe` or `syncCloudVersionTo()`
pure name like `sync` sounds like a "pull" or "get" request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
