gavinchou commented on code in PR #60467:
URL: https://github.com/apache/doris/pull/60467#discussion_r2789529893
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudPartition.java:
##########
@@ -272,15 +299,24 @@ public static List<Long>
getSnapshotVisibleVersion(List<CloudPartition> partitio
// partitionId -> cachedVersion
List<Pair<Long, Long>> allVersions = new
ArrayList<>(partitions.size());
List<CloudPartition> expiredPartitions = new
ArrayList<>(partitions.size());
- for (CloudPartition partition : partitions) {
- long ver = partition.getCachedVisibleVersion();
- if (partition.isCachedVersionExpired()) {
- expiredPartitions.add(partition);
- ver = 0L; // 0 means to be get from meta-service
+ List<OlapTable> tables = getTables(partitions);
+ for (OlapTable table : tables) {
+ table.versionReadLock();
Review Comment:
is there any performance issues for high frequent query low frequent load --
the write lock may starve?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
