wrlcke commented on code in PR #60833:
URL: https://github.com/apache/doris/pull/60833#discussion_r2931766906
##########
be/test/exprs/aggregate/agg_function_test.h:
##########
@@ -179,8 +179,11 @@ struct AggregateFunctiontest : public testing::Test {
agg_fn->create(place);
Defer defer([&]() { agg_fn->destroy(place); });
- agg_fn->function()->deserialize_and_merge_from_column_range(
- place, *serialize_column, 0, block.rows() - 1, arena);
+
+ if (block.rows() != 0) {
Review Comment:
Do you mean there might be a case where an empty block is supposed to
trigger an error?
In this test framework, the block is provided by the test author, so if it
contains zero rows it usually means the test intentionally wants to verify the
behavior on empty input. In such cases there’s nothing to merge here so it
should be skipped (in other merge path it's naturally skipped but here
streaming_agg_serialize_to_column will produce an empty column)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
