englefly opened a new pull request, #61343:
URL: https://github.com/apache/doris/pull/61343
## Problem
In the Nereids optimizer, every plan node (both logical and physical)
carries a unique ObjectId (`AbstractPlan.id`). Previously, every call to a
`withXxx()` method (e.g. `withChildren`, `withGroupExpression`,
`withGroupExprLogicalPropChildren`, `withPhysicalPropertiesAndStats`)
constructed a brand-new node that was allocated a fresh id via
`StatementScopeIdGenerator.newObjectId()`. This means a node and its "copy" had
different ids even though they represent the same operator, which can confuse
plan identification, caching, and debugging.
## Solution
Introduce a thread-local id-inheritance mechanism in `AbstractPlan`:
1. Add `private static final ThreadLocal<ObjectId> INHERIT_ID` to
`AbstractPlan`.
2. Add a static helper `AbstractPlan.copyWithSameId(source, factory)`: it
stores `source.id` in the ThreadLocal, calls the constructor through the
supplied lambda, and clears the ThreadLocal in a `finally` block.
3. Modify the constructor to read and clear `INHERIT_ID` when present;
otherwise allocate a fresh id as before.
4. Rewrite all `withXxx()` methods in every logical and physical plan node
(60 logical + 51 physical, ~490 call sites) to use
`AbstractPlan.copyWithSameId(this, () -> new ...)`.
This approach keeps `id` final-by-contract (only set once in the
constructor), is thread-safe without locking, and requires no changes to
callers outside the plan-node classes themselves.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
