github-actions[bot] commented on PR #61842:
URL: https://github.com/apache/doris/pull/61842#issuecomment-4151897176
## Code Review Summary
**PR**: [chore](regression) Merge nereids_p0 test cases into query_p0
### Overview
This PR consolidates regression tests by merging unique test content from
`nereids_p0` into `query_p0` and deleting the duplicate `nereids_p0` files. ~42
Groovy test files modified in `query_p0`, ~24 `.out` files updated, and
hundreds of `nereids_p0` files deleted. No production code changes.
### Part 1.3 Critical Checkpoint Conclusions
| Checkpoint | Conclusion |
|---|---|
| Goal accomplished? | ✅ Yes — unique test cases merged, duplicates removed |
| Minimal and focused? | ✅ Yes — purely test reorganization |
| Concurrency? | N/A — no concurrent code |
| Lifecycle management? | N/A |
| Configuration items? | N/A |
| Incompatible changes? | N/A |
| Parallel code paths? | N/A |
| Special conditional checks? | N/A |
| Test coverage? | ✅ Preserved — unique cases merged, not dropped |
| Observability? | N/A |
| Transaction/persistence? | N/A |
| Data writes? | N/A |
| FE-BE variables? | N/A |
| Performance? | N/A |
| Other issues? | None found |
### Test Pattern Verification (Part 4.1)
- **`order_qt_` or explicit `ORDER BY`**: ✅ Used appropriately in modified
files
- **Error patterns**: ✅ `test { sql ...; exception ... }` used where
applicable
- **Tables dropped before use**: ✅ `DROP TABLE IF EXISTS` before `CREATE
TABLE`
- **Hardcoded table names**: ✅ No new `def tableName` patterns introduced
- **`.out` files auto-generated**: ✅ Appear machine-generated (not
handwritten)
### Key Verifications
1. **No leftover references**: Confirmed no remaining references to
`nereids_test_query_db`, `enable_nereids_planner`, or `nereids_p0` paths in
added lines
2. **No suite name conflicts**: Deleted `nereids_p0` files had identical
suite names to their `query_p0` counterparts (pre-existing duplicates resolved
by this PR)
3. **Cleanup of obsolete settings**: Correctly removes
`enable_nereids_planner` and `enable_fallback_to_original_planner` settings
which are now defaults
### Verdict
No issues found. Clean test consolidation PR that preserves all unique test
coverage while eliminating duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
