morrySnow commented on code in PR #61842:
URL: https://github.com/apache/doris/pull/61842#discussion_r3007590793
##########
regression-test/suites/query_p0/aggregate/aggregate_group_by_metric_type.groovy:
##########
@@ -64,4 +61,29 @@ suite("aggregate_group_by_metric_type") {
exception "${error_msg}"
}
sql "DROP TABLE test_group_by_hll_and_bitmap"
+
+ sql "DROP TABLE IF EXISTS test_group_by_array"
+ sql """
+ CREATE TABLE IF NOT EXISTS test_group_by_array (id int, c_array
array<int>) ENGINE=OLAP DUPLICATE KEY(`id`)
+ DISTRIBUTED BY HASH(`id`) BUCKETS 1 properties("replication_num" =
"1");
+ """
+ sql "insert into test_group_by_array values(1, [1,2,3])"
+
+ // Nereids does't support array function
+ // test {
+ // sql "select distinct c_array from test_group_by_array"
+ // exception "${error_msg}"
+ // }
+ // Nereids does't support array function
+ // test {
+ // sql "select c_array from test_group_by_array order by c_array"
+ // exception "${error_msg}"
+ // }
+ // Nereids does't support array function
+ // test {
+ // sql "select c_array,count(*) from test_group_by_array group by
c_array"
+ // exception "${error_msg}"
+ // }
+
+ sql "DROP TABLE test_group_by_array"
Review Comment:
Done. Removed all the commented-out Nereids array function test blocks in
829b76d.
##########
regression-test/suites/query_p0/hbo/hbo_agg_stage_opt_test.groovy:
##########
@@ -30,7 +30,7 @@ suite("hbo_agg_stage_opt_test", "nonConcurrent") {
sql "set hbo_rfsafe_threshold=1.0;"
sql "set enable_hbo_optimization=false;";
sql "set global enable_hbo_info_collection=true;";
- sql """ ADMIN SET ALL FRONTENDS CONFIG ("hbo_slow_query_threshold_ms" =
"10"); """
+ try { sql """ ADMIN SET ALL FRONTENDS CONFIG
("hbo_slow_query_threshold_ms" = "10"); """ } catch (Exception ignored) {}
Review Comment:
You're right, try-catch is not the correct approach. The config
`hbo_slow_query_threshold_ms` doesn't exist in current FE source code (it was
removed at some point after PR #48808 introduced it). I've removed the ADMIN
SET lines entirely from all 8 hbo test files instead of wrapping them in
try-catch. Fixed in 829b76d.
##########
regression-test/suites/nereids_p0/repeat/test_repeat_output_slot.groovy:
##########
@@ -16,17 +16,6 @@
// under the License.
suite("test_repeat_output_slot") {
- sql """
- SET enable_fallback_to_original_planner=false;
- SET enable_nereids_planner=true;
- SET ignore_shape_nodes='PhysicalDistribute';
- SET disable_nereids_rules='PRUNE_EMPTY_PARTITION';
- SET runtime_filter_mode=OFF;
- SET disable_join_reorder=true;
-
- DROP TABLE IF EXISTS tbl_test_repeat_output_slot FORCE;
Review Comment:
Fixed. The SET statements (`ignore_shape_nodes`, `disable_nereids_rules`,
`runtime_filter_mode`, `disable_join_reorder`) and `DROP TABLE IF EXISTS` were
incorrectly removed when we stripped nereids-specific settings. They've been
restored in 829b76d.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
