kaka11chen opened a new pull request, #63189:
URL: https://github.com/apache/doris/pull/63189
### What problem does this PR solve?
Related PR: #62403
Problem Summary:
### Release note
Cloud download callback already attaches the SnapshotLoader resource
context.
During cloud restore, CloudSnapshotLoader::download() calls
CloudSnapshotMgr::make_snapshot(), which previously used SCOPED_ATTACH_TASK
again and could hit ThreadContext::attach_task() DCHECK because task
attach is
not nestable.
Use SCOPED_SWITCH_THREAD_MEM_TRACKER_LIMITER in CloudSnapshotMgr snapshot
operations avoiding the nested-attach pattern. These methods only need to
account memory to the manager tracker, and limiter switching works both
with
and without an outer attached task context.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
