Copilot commented on code in PR #63189:
URL: https://github.com/apache/doris/pull/63189#discussion_r3228504570
##########
be/src/cloud/cloud_snapshot_mgr.cpp:
##########
@@ -61,7 +61,7 @@ CloudSnapshotMgr::CloudSnapshotMgr(CloudStorageEngine&
engine) : _engine(engine)
Status CloudSnapshotMgr::make_snapshot(int64_t target_tablet_id,
StorageResource& storage_resource,
std::unordered_map<std::string,
std::string>& file_mapping,
bool is_restore, const Slice* slice) {
Review Comment:
Consider adding a short inline comment explaining why
`SCOPED_SWITCH_THREAD_MEM_TRACKER_LIMITER` must be used here (to avoid nested
`attach_task()` during cloud download/restore callbacks). This is a subtle
invariant and the next refactor could easily revert to `SCOPED_ATTACH_TASK` and
reintroduce the DCHECK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
