github-actions[bot] commented on code in PR #62510:
URL: https://github.com/apache/doris/pull/62510#discussion_r3231031488
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/InsertOverwriteTableCommand.java:
##########
@@ -489,7 +489,7 @@ public Optional<NereidsPlanner>
getExplainPlanner(LogicalPlan logicalPlan, State
}
public boolean isForceDropPartition() {
- return false;
+ return true;
}
Review Comment:
This only changes the non-auto-detect path at `run()` lines 270-271. `INSERT
OVERWRITE ... PARTITION(*)` goes through `isAutoDetectOverwrite()` and commits
via `InsertOverwriteManager.taskGroupSuccess()`, which still calls
`InsertOverwriteUtil.replacePartition(targetTable, oldNames, newNames)` without
the force flag, so those replaced partitions are still moved to the recycle bin
and remain recoverable. That leaves a supported insert-overwrite mode with the
old behavior and continues to add recycle-bin load. Please propagate the
force-drop behavior through the task-group success path as well, and add
coverage for the auto-detect case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
