github-actions[bot] commented on code in PR #62510: URL: https://github.com/apache/doris/pull/62510#discussion_r3232498064
########## regression-test/suites/catalog_recycle_bin_p0/test_insert_overwrite_recover.groovy: ########## @@ -1,64 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one -// or more contributor license agreements. See the NOTICE file -// distributed with this work for additional information -// regarding copyright ownership. The ASF licenses this file -// to you under the Apache License, Version 2.0 (the -// "License"); you may not use this file except in compliance -// with the License. You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, -// software distributed under the License is distributed on an -// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -// KIND, either express or implied. See the License for the -// specific language governing permissions and limitations -// under the License. - -suite("test_insert_overwrite_recover") { - def table = "test_insert_overwrite_recover" - - // create table and insert data - sql """ drop table if exists ${table}""" - sql """ - create table ${table} ( - `id` int(11), - `name` varchar(128), - `da` date - ) - engine=olap - duplicate key(id) - partition by range(da)( - PARTITION p3 VALUES LESS THAN ('2023-01-01'), - PARTITION p4 VALUES LESS THAN ('2024-01-01'), - PARTITION p5 VALUES LESS THAN ('2025-01-01') - ) - distributed by hash(id) buckets 2 - properties( - "replication_num"="1", - "light_schema_change"="true" - ); - """ - - sql """ insert into ${table} values(1, 'a', '2022-01-02'); """ - sql """ insert into ${table} values(2, 'a', '2023-01-02'); """ - sql """ insert into ${table} values(3, 'a', '2024-01-02'); """ - sql """ SYNC;""" - - qt_select_check_1 """ select * from ${table} order by id,name,da; """ - - sql """ insert overwrite table ${table} values(3, 'a', '2024-01-02'); """ - - qt_select_check_1 """ select * from ${table} order by id,name,da; """ - - sql """ ALTER TABLE ${table} DROP PARTITION p3 force; """ - sql """ ALTER TABLE ${table} DROP PARTITION p4 force; """ - sql """ ALTER TABLE ${table} DROP PARTITION p5 force; """ - - sql """ recover partition p3 from ${table}; """ - sql """ recover partition p4 from ${table}; """ - sql """ recover partition p5 from ${table}; """ Review Comment: This PR changes the user-visible recycle-bin semantics for INSERT OVERWRITE, but it only deletes the tests that validated the old recoverable behavior. Please add replacement regression coverage that proves the new behavior: after INSERT OVERWRITE, `recover partition`/table recovery should fail or no longer expose the overwritten data. This should cover the direct partition/whole-table cases and the auto-detect `PARTITION(*)` path that now propagates `forceDropPartition`; otherwise the new behavior can regress without any test failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
