github-actions[bot] commented on code in PR #63168:
URL: https://github.com/apache/doris/pull/63168#discussion_r3231593095
##########
be/src/format/parquet/vparquet_group_reader.cpp:
##########
@@ -751,6 +751,7 @@ Status RowGroupReader::_do_lazy_read(Block* block, size_t
batch_size, size_t* re
DCHECK_EQ(pre_read_rows + _cached_filtered_rows, 0);
*read_rows = 0;
*batch_eof = true;
+ _convert_dict_cols_to_string_cols(block);
Review Comment:
This helper returns `Status` and `Status` is `[[nodiscard]]`, so this call
must be propagated. More importantly, if `_get_block_column_pos()` or
`convert_dict_column_to_string_column()` fails, this path currently returns
`OK` with the block left in the dictionary-code representation, unlike all
adjacent `_convert_dict_cols_to_string_cols` call sites that use
`RETURN_IF_ERROR`. Please keep the same error handling here.
```suggestion
RETURN_IF_ERROR(_convert_dict_cols_to_string_cols(block));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
