Gabriel39 commented on PR #63168: URL: https://github.com/apache/doris/pull/63168#issuecomment-4437509544
> > @yoock Please add regression test cases. > > 这个很难构造回归测试案例 @Gabriel39 > > 本质上就是RowGroupReader::next_batch结束时必须调用_convert_dict_cols_to_string_cols(block);，但是这里漏了 你修改的这个codepath是不是只有两种情况会被执行，一种是上查询被cancel了，另一种是当前这个block读出来是空（也就是pre_read_rows为0，pre_eof为true的时候），如果是这两种情况的话，为什么我们还需要关心block里面的实际数据是什么？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
