github-actions[bot] commented on code in PR #63306:
URL: https://github.com/apache/doris/pull/63306#discussion_r3257739477
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -1826,6 +1828,25 @@ private void transferToMaster() {
editLog.logMasterInfo(masterInfo);
LOG.info("logMasterInfo:{}", masterInfo);
+ if (Boolean.getBoolean(FeConstants.DROP_BACKENDS_KEY)) {
+ LOG.info("drop_backends is set, dropping all backends...");
Review Comment:
`Boolean.getBoolean(FeConstants.DROP_BACKENDS_KEY)` remains true for the
lifetime of this FE process. `transferToMaster()` is not a one-time startup
hook; the type-transfer loop calls it for `INIT -> MASTER`, `UNKNOWN ->
MASTER`, and `FOLLOWER -> MASTER`, so a FE started once with `--drop_backends`
can drop the newly registered/current backends again after a later master
re-election. This recovery flag should be consumed once (for example clear it
after a successful drop, while still failing the transition on drop errors as
noted in the existing thread) or otherwise scoped so subsequent master
transitions cannot repeat the destructive action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
