github-actions[bot] commented on code in PR #63306:
URL: https://github.com/apache/doris/pull/63306#discussion_r3258520812
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -1826,6 +1828,26 @@ private void transferToMaster() {
editLog.logMasterInfo(masterInfo);
LOG.info("logMasterInfo:{}", masterInfo);
+ if (Boolean.getBoolean(FeConstants.DROP_BACKENDS_KEY)) {
+ LOG.info("drop_backends is set, dropping all backends...");
+ try {
+ SystemInfoService systemInfoService =
Env.getCurrentSystemInfo();
+ List<Backend> bes =
systemInfoService.getAllClusterBackendsNoException().values()
+ .stream().collect(Collectors.toList());
+ if (Config.isNotCloudMode()) {
+ for (Backend be : bes) {
+ systemInfoService.dropBackend(be.getHost(),
be.getHeartbeatPort());
+ }
Review Comment:
This cloud-mode path only calls `updateCloudBackends()`, which is the
FE-local bookkeeping helper: it logs `logDropBackend`, removes entries from
`idToBackendRef`, report-version maps, and cloud cluster maps, but it does not
send an `AlterClusterRequest` to the meta-service. In contrast, cloud
`dropBackend()` uses `alterBackendCluster(..., DROP_NODE)` so the remote
cluster state is changed. The recovery script now passes `--drop_backends`
specifically in cloud recovery, so after this branch the restored FE can
believe the BEs are gone while meta-service still has the nodes; later cluster
sync/get-cluster paths can reintroduce them or leave FE/meta-service
inconsistent. Please use the cloud drop path (or a batch meta-service drop) so
the cloud source of truth is updated before clearing the flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
