yiguolei commented on code in PR #63291:
URL: https://github.com/apache/doris/pull/63291#discussion_r3287176137
##########
be/src/storage/segment/page_io.cpp:
##########
@@ -232,11 +232,15 @@ Status PageIO::read_and_decompress_page_(const
PageReadOptions& opts, PageHandle
if (opts.pre_decode) {
const auto* encoding_info = opts.encoding_info;
if (opts.is_dict_page) {
- // for dict page, we need to use encoding_info based on
footer->dict_page_footer().encoding()
- // to get its pre_decoder
-
RETURN_IF_ERROR(EncodingInfo::get(FieldType::OLAP_FIELD_TYPE_VARCHAR,
-
footer->dict_page_footer().encoding(), {},
- &encoding_info));
+ // Look up the dict page's encoding_info using the outer column's
+ // field type (not a hardcoded VARCHAR), so CHAR columns reach the
+ // CharStrip pre-decoder for the dict pool too. Falls back to
+ // VARCHAR only when the caller didn't set opts.encoding_info.
+ FieldType dict_field_type = opts.encoding_info != nullptr
Review Comment:
什么时候encoding info == nullptr？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
