yiguolei commented on code in PR #63291:
URL: https://github.com/apache/doris/pull/63291#discussion_r3287201584
##########
be/src/storage/key_coder.h:
##########
@@ -55,8 +59,8 @@ class KeyCoder {
KeyCoder(TraitsType traits);
// encode the provided `value` into `buf`.
- void full_encode_ascending(const void* value, std::string* buf) const {
- _full_encode_ascending(value, buf);
+ void full_encode_ascending(const void* value, std::string* buf, size_t
char_len = 0) const {
Review Comment:
我感觉这里写的不太好。
实际我们是一个模板，一定会传入类型的。
我们不如直接写个新的函数full_encode_ascending(const void* value, std::string* buf,
size_t char_len)。以前的函数保持不变，直接在char 类型的时候，看看编译能否报错。
然后新的函数只有char 类型实现，其他类型也编译报错。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
