yiguolei commented on code in PR #63919:
URL: https://github.com/apache/doris/pull/63919#discussion_r3332129174
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -1072,6 +1075,15 @@ public static double getHotValueThreshold() {
@VarAttrDef.VarAttr(name = INSERT_VISIBLE_TIMEOUT_MS, needForward = true)
public long insertVisibleTimeoutMs = DEFAULT_INSERT_VISIBLE_TIMEOUT_MS;
+ // Control whether publish timeout keeps the committed response or returns
an explicit error.
+ @VarAttrDef.VarAttr(name = INSERT_VISIBLE_TIMEOUT_RETURN_MODE, needForward
= true,
+ checker = "checkInsertVisibleTimeoutReturnMode", setter =
"setInsertVisibleTimeoutReturnMode",
+ description = {"控制普通内表 INSERT 在 publish timeout 时返回给客户端的状态。",
+ "Controls the status returned to the client when a normal
internal-table INSERT times out "
+ + "while waiting for publish visibility."},
+ options = {INSERT_VISIBLE_TIMEOUT_RETURN_MODE_COMMITTED,
INSERT_VISIBLE_TIMEOUT_RETURN_MODE_ERROR})
+ public String insertVisibleTimeoutReturnMode =
INSERT_VISIBLE_TIMEOUT_RETURN_MODE_COMMITTED;
Review Comment:
一般把这些不同种类的各种mode 定义为enum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
