yiguolei commented on code in PR #63919:
URL: https://github.com/apache/doris/pull/63919#discussion_r3332139663


##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -269,6 +269,9 @@ public class SessionVariable implements Serializable, 
Writable {
 
     // max ms to wait transaction publish finish when exec insert stmt.
     public static final String INSERT_VISIBLE_TIMEOUT_MS = 
"insert_visible_timeout_ms";
+    public static final String INSERT_VISIBLE_TIMEOUT_RETURN_MODE = 
"insert_visible_timeout_return_mode";
+    public static final String INSERT_VISIBLE_TIMEOUT_RETURN_MODE_COMMITTED = 
"committed";
+    public static final String INSERT_VISIBLE_TIMEOUT_RETURN_MODE_ERROR = 
"error";

Review Comment:
   一般把这些不同种类的各种mode 定义为enum



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to