gavinchou commented on code in PR #63818:
URL: https://github.com/apache/doris/pull/63818#discussion_r3345877601
##########
be/src/io/fs/file_reader.h:
##########
@@ -79,6 +83,8 @@ class FileReader : public doris::ProfileCollector {
/// the caller must ensure that the IOContext exists during the left cycle
of read_at()
Status read_at(size_t offset, Slice result, size_t* bytes_read,
const IOContext* io_ctx = nullptr);
+ Status read_at_iobuf(size_t offset, size_t bytes_req, butil::IOBuf* out,
size_t* bytes_read,
Review Comment:
add comment for this interface
##########
be/src/io/fs/file_reader.h:
##########
@@ -79,6 +83,8 @@ class FileReader : public doris::ProfileCollector {
/// the caller must ensure that the IOContext exists during the left cycle
of read_at()
Status read_at(size_t offset, Slice result, size_t* bytes_read,
const IOContext* io_ctx = nullptr);
+ Status read_at_iobuf(size_t offset, size_t bytes_req, butil::IOBuf* out,
size_t* bytes_read,
Review Comment:
param and behaviors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
