gavinchou commented on code in PR #63818:
URL: https://github.com/apache/doris/pull/63818#discussion_r3345882957
##########
be/src/io/fs/local_file_reader.cpp:
##########
@@ -194,5 +195,50 @@ Status LocalFileReader::read_at_impl(size_t offset, Slice
result, size_t* bytes_
return Status::OK();
}
+Status LocalFileReader::read_at_iobuf_impl(size_t offset, size_t bytes_req,
butil::IOBuf* out,
Review Comment:
add UT
##########
be/src/io/fs/local_file_writer.cpp:
##########
@@ -187,6 +189,47 @@ Status LocalFileWriter::appendv(const Slice* data, size_t
data_cnt) {
return Status::OK();
}
+Status LocalFileWriter::append_iobuf(const butil::IOBuf& data) {
Review Comment:
add UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
