github-actions[bot] commented on code in PR #64285:
URL: https://github.com/apache/doris/pull/64285#discussion_r3378856823
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -1242,10 +1227,6 @@ public void checkQuerySlotCount(String slotCnt) {
@VarAttrDef.VarAttr(name = AUTO_COMMIT, convertBoolToLongMethod =
"convertBoolToLong")
public boolean autoCommit = true;
- // this is used to make c3p0 library happy
- @VarAttrDef.VarAttr(name = TX_ISOLATION)
Review Comment:
This removes `tx_isolation`, but that variable is not part of the audited
dead TQueryOptions fields and the existing comment explicitly says it is for
c3p0 compatibility. After this patch, `SELECT @@tx_isolation` is handled by the
removed-variable fallback and returns an empty string instead of
`REPEATABLE-READ`. MySQL/JDBC clients commonly probe this variable and may
parse or compare the returned isolation level, so silently returning `""` is
not equivalent compatibility. Please keep `tx_isolation` (or make the
removed-variable fallback return the previous `REPEATABLE-READ` value for this
name) and add a compatibility test for `SELECT @@tx_isolation`.
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -1395,7 +1376,7 @@ public void checkQuerySlotCount(String slotCnt) {
* 1 means disable this feature
*/
@VarAttrDef.VarAttr(name = PARALLEL_FRAGMENT_EXEC_INSTANCE_NUM,
needForward = true, fuzzy = false,
- setter = "setFragmentInstanceNum", varType =
VariableAnnotation.DEPRECATED)
+ varType = VariableAnnotation.DEPRECATED)
Review Comment:
Dropping the no-op setter changes `SET parallel_fragment_exec_instance_num =
...` from an ignored deprecated variable into a variable that appears to change
successfully. However `getParallelExecInstanceNum()` no longer reads
`parallelExecInstanceNum`; it returns the user property, auto value, or
`parallelPipelineTaskNum`. That means users can now set and see a value that
has no execution effect. Please keep the no-op setter (or remove/deprecate the
variable consistently through the removed-variable path) so the session surface
does not become misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
