github-actions[bot] commented on code in PR #64285:
URL: https://github.com/apache/doris/pull/64285#discussion_r3379031654
##########
fe/fe-core/src/main/java/org/apache/doris/qe/VariableMgr.java:
##########
@@ -148,7 +148,13 @@ public class VariableMgr {
"enable_eliminate_sort_node",
"drop_table_if_ctas_failed",
"trace_nereids",
- "enable_sync_mv_cost_based_rewrite");
+ "enable_sync_mv_cost_based_rewrite",
+ "enable_vectorized_engine",
+ "enable_common_expr_pushdown",
+ "enable_common_expr_pushdown_for_inverted_index",
+ "enable_phrase_query_sequential_opt",
+ "enable_rust_lance_reader",
+ "shuffled_agg_node_ids");
Review Comment:
`shuffled_agg_node_ids` was declared as `VariableAnnotation.EXPERIMENTAL`,
so before this change both `SET shuffled_agg_node_ids = ...` and `SET
experimental_shuffled_agg_node_ids = ...` were accepted by `getVarContext()`
(it strips the experimental prefix and then validates it against the field
annotation). After the field is removed, the fallback checks
`isRemovedSessionVar(setVar.getVariable())` against the original name, and only
the unprefixed spelling is whitelisted here. Existing scripts that use the
displayed experimental name will now get `ERR_UNKNOWN_SYSTEM_VARIABLE`, which
breaks the compatibility goal described in the PR. Please also whitelist
`experimental_shuffled_agg_node_ids` (and add a regression/unit check for the
prefixed form).
```suggestion
"shuffled_agg_node_ids",
"experimental_shuffled_agg_node_ids");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
