morrySnow commented on code in PR #63366:
URL: https://github.com/apache/doris/pull/63366#discussion_r3412773289
##########
fe/fe-core/src/main/java/org/apache/doris/planner/PlanNode.java:
##########
@@ -824,14 +828,97 @@ public void
foreachDownInCurrentFragment(Consumer<PlanNode> visitor) {
});
}
- // Operators need to be executed serially. (e.g. finalized agg without key)
- public boolean isSerialOperator() {
+ /**
+ * Node-level "is this operator inherently serial" property — answers
without looking
+ * at the fragment. Default false; subclasses override (e.g. finalized
agg without key,
+ * UNPARTITIONED ExchangeNode with merge sort).
+ *
+ * Use ONLY in framework-internal places where we are already iterating
within a
+ * fragment whose serial-source mode is fixed: {@link
#shouldResetSerialFlagForChild}
+ * inputs, {@link #createLocalExchange} heavy-op gate, and
child.isSerialNode() checks
+ * embedded inside an enforceRequire path. Do NOT use it when computing a
+ * {@link LocalExchangeNode.LocalExchangeTypeRequire} on a child — call
+ * {@link #isSerialOperatorOnBe} instead.
+ */
+ public boolean isSerialNode() {
Review Comment:
it should be protected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
