BiteTheDDDDt commented on code in PR #63366: URL: https://github.com/apache/doris/pull/63366#discussion_r3413115610
########## be/src/udf/python/boost_process_compat.h: ########## @@ -0,0 +1,28 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once Review Comment: 这些无关的改动能不能单独抽出来单独提 ########## be/src/exec/pipeline/pipeline_fragment_context.cpp: ########## @@ -290,6 +290,32 @@ Status PipelineFragmentContext::_build_and_prepare_full_pipeline(ThreadPool* thr RETURN_IF_ERROR(_build_pipelines(_runtime_state->obj_pool(), *_query_ctx->desc_tbl, &_root_op, root_pipeline)); + // Propagate _num_instances from LOCAL_EXCHANGE pipelines to ancestor pipelines + // that inherited reduced num_tasks from a serial operator. + _propagate_local_exchange_num_tasks(); + + // Create deferred local exchangers now that all pipelines have final num_tasks. + RETURN_IF_ERROR(_create_deferred_local_exchangers()); Review Comment: 我没懂如果fe一开始就把所有local exchange规划好，所有算子的并行度规划好，直接下发。be为什么需要_create_deferred_local_exchangers和_propagate_local_exchange_num_tasks？ 这个是现在设计出来就是要先做折中方案的，还是可以直接一把做全面？_propagate_local_exchange_num_tasks和_create_deferred_local_exchangers这两块新增的应该不是为了灰度/回滚吧。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
