HappenLee commented on code in PR #64165:
URL: https://github.com/apache/doris/pull/64165#discussion_r3448181953
##########
be/src/storage/predicate/block_column_predicate.cpp:
##########
@@ -28,6 +28,24 @@ namespace segment_v2 {
class InvertedIndexIterator;
} // namespace segment_v2
+namespace {
+
+template <typename EvaluateFunc>
+bool evaluate_and_with_scan_filter(
+ const std::vector<std::unique_ptr<BlockColumnPredicate>>& predicates,
ScanFilterStage stage,
+ int64_t input_rows, EvaluateFunc&& evaluate_func) {
+ bool all_matched = true;
+ for (const auto& predicate : predicates) {
+ // Keep scan filter attribution independent from AND short-circuiting.
+ const bool matched = evaluate_func(*predicate);
Review Comment:
这个不保留短路逻辑不会有性能问题吗？短路之后其他filter为什么要统计
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
