HappenLee commented on code in PR #64165:
URL: https://github.com/apache/doris/pull/64165#discussion_r3448196598
##########
be/src/storage/segment/column_reader.cpp:
##########
@@ -438,9 +449,11 @@ Status ColumnReader::get_row_ranges_by_zone_map(
const std::vector<std::shared_ptr<const ColumnPredicate>>*
delete_predicates,
RowRanges* row_ranges, const ColumnIteratorOptions& iter_opts) {
std::vector<uint32_t> page_indexes;
- RETURN_IF_ERROR(
- _get_filtered_pages(col_predicates, delete_predicates,
&page_indexes, iter_opts));
- RETURN_IF_ERROR(_calculate_row_ranges(page_indexes, row_ranges,
iter_opts));
+ RETURN_IF_ERROR(_get_filtered_pages(col_predicates, delete_predicates,
*row_ranges,
+ &page_indexes, iter_opts));
+ RowRanges zone_map_row_ranges;
Review Comment:
这几行的改动有什么意义？感觉和之前没区别，还引入一个zone_map_row_ranges？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
