yiguolei commented on code in PR #64413:
URL: https://github.com/apache/doris/pull/64413#discussion_r3450358294
##########
be/src/storage/iterator/vcollect_iterator.cpp:
##########
@@ -288,22 +288,20 @@ Status VCollectIterator::_topn_next(Block* block) {
}
auto clone_block = block->clone_empty();
- // Initialize virtual slot columns by schema (avoid runtime type checks):
- // use _reader_context.vir_col_idx_to_type to construct real columns for
those positions.
- if (!_reader->_reader_context.vir_col_idx_to_type.empty()) {
- const auto& idx_to_type = _reader->_reader_context.vir_col_idx_to_type;
- for (const auto& kv : idx_to_type) {
- size_t idx = kv.first;
- if (idx < clone_block.columns()) {
- clone_block.get_by_position(idx).column =
kv.second->create_column();
- }
- }
- }
+ // Initialize virtual slot columns by schema (avoid runtime type checks).
+ for (const auto& [cid, expr_ctx] :
_reader->_reader_context.virtual_column_exprs) {
+ auto it = std::find(_reader->_return_columns.begin(),
_reader->_return_columns.end(), cid);
+ DORIS_CHECK(it != _reader->_return_columns.end());
+ auto idx =
cast_set<size_t>(std::distance(_reader->_return_columns.begin(), it));
+ DORIS_CHECK(idx < clone_block.columns());
+ clone_block.get_by_position(idx).column =
expr_ctx->root()->data_type()->create_column();
Review Comment:
这里为什么要clone 一个block？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
